[nos-bbs] Fwd: Re: gcc ARM + color issue + (yeah) UNSIGNED forced on char !!!

[M Langelaar]

This is important for everyone to know, thanks for the report Jean.

-------- Forwarded Message --------
Subject: 	Re: [nos-bbs] gcc ARM + color issue + (yeah) UNSIGNED forced 
on char !!!
Date: 	Mon, 17 Feb 2020 03:47:51 -0600
From: 	VE2PKT <ve2pkt at gmail.com>
To: 	M Langelaar <maiko at pcsinternet.ca>



Hello Maiko,

       the -fsigned-char appear to have fixed more then just the colors. 
I started my Jnos with out the 
LD_PRELOAD=/usr/lib/arm-linux-gnueabihf/libarmmem-v6l.so ./jnos
  and I can NNTP with out any crash.


Good job.

73 de Jean




On 2020-02-16 10:19 p.m., M Langelaar wrote:
> Yes,
>
> it will now be PATCHES = -DDEBUG -fsigned-char
>
> Maiko
>
> On 16/02/2020 9:38 p.m., VE2PKT wrote:
>> Hello Maiko,
>>
>>     I do not have PATCHES-directive, I only have PATCHES = -DDEBUG
>>
>> is that where I add the -fsigned-char ?
>>
>>
>> 73 de Jean
>>
>>
>> On 2020-02-16 8:34 p.m., M Langelaar wrote:
>>> Another wake up call ? apparently more efficient for ARM to use 
>>> unsigned then signed.
>>>
>>> The reason color is not working is gcc on the ARM processor (ie, 
>>> raspbian on PI 4)
>>> automatically defaults char to UNSIGNED, unlike on a non-ARM 
>>> processor. So what
>>> happens is if you initialize an array (ie, color maps) with -1, it 
>>> automatically makes
>>> it a 255 instead (since -1 is not possible on an unsigned char). 
>>> Then the rest of the
>>> code has trouble since all the conditions are looking for a -1, not 
>>> a 255. I found it
>>> via several debug lines I put into the JNOS curses.c.
>>>
>>> SOO this potentially brings up more then just color issues, possible 
>>> instability ?
>>>
>>> What else gets 'broke' in the ARM version of JNOS ? So here is a 
>>> request from
>>> me to the PI people, please edit your makefile and add the following :
>>>
>>>     -fsigned-char
>>>
>>> to the end of the PATCHES = directive
>>>
>>> Then make clean, ./configure, make
>>>
>>> Your color should now work and hopefully JNOS will be more stable ? 
>>> Let it run
>>> for a while, notice if anything improves or gets worse ? Whatever 
>>> you can do.
>>>
>>> Thank you.
>>>
>>> Maiko / VE4KLM
>>>
>>>
>>> _______________________________________________
>>> nos-bbs mailing list
>>> nos-bbs at lists.tapr.org
>>> http://lists.tapr.org/mailman/listinfo/nos-bbs_lists.tapr.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.tapr.org/pipermail/nos-bbs_lists.tapr.org/attachments/20200217/28d2c452/attachment.html>