<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>This is important for everyone to know, thanks for the report
Jean.<br>
</p>
<div class="moz-forward-container">-------- Forwarded Message
--------
<table class="moz-email-headers-table" cellspacing="0"
cellpadding="0" border="0">
<tbody>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">Subject:
</th>
<td>Re: [nos-bbs] gcc ARM + color issue + (yeah) UNSIGNED
forced on char !!!</td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">Date: </th>
<td>Mon, 17 Feb 2020 03:47:51 -0600</td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">From: </th>
<td>VE2PKT <a class="moz-txt-link-rfc2396E" href="mailto:ve2pkt@gmail.com"><ve2pkt@gmail.com></a></td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">To: </th>
<td>M Langelaar <a class="moz-txt-link-rfc2396E" href="mailto:maiko@pcsinternet.ca"><maiko@pcsinternet.ca></a></td>
</tr>
</tbody>
</table>
<br>
<br>
Hello Maiko,<br>
<br>
the -fsigned-char appear to have fixed more then just the
colors. I started my Jnos with out the
LD_PRELOAD=/usr/lib/arm-linux-gnueabihf/libarmmem-v6l.so ./jnos<br>
and I can NNTP with out any crash.<br>
<br>
<br>
Good job.<br>
<br>
73 de Jean<br>
<br>
<br>
<br>
<br>
On 2020-02-16 10:19 p.m., M Langelaar wrote:<br>
<blockquote type="cite">Yes,<br>
<br>
it will now be PATCHES = -DDEBUG -fsigned-char<br>
<br>
Maiko<br>
<br>
On 16/02/2020 9:38 p.m., VE2PKT wrote:<br>
<blockquote type="cite">Hello Maiko,<br>
<br>
I do not have PATCHES-directive, I only have PATCHES =
-DDEBUG<br>
<br>
is that where I add the -fsigned-char ?<br>
<br>
<br>
73 de Jean<br>
<br>
<br>
On 2020-02-16 8:34 p.m., M Langelaar wrote:<br>
<blockquote type="cite">Another wake up call ? apparently more
efficient for ARM to use unsigned then signed.<br>
<br>
The reason color is not working is gcc on the ARM processor
(ie, raspbian on PI 4)<br>
automatically defaults char to UNSIGNED, unlike on a non-ARM
processor. So what<br>
happens is if you initialize an array (ie, color maps) with
-1, it automatically makes<br>
it a 255 instead (since -1 is not possible on an unsigned
char). Then the rest of the<br>
code has trouble since all the conditions are looking for a
-1, not a 255. I found it<br>
via several debug lines I put into the JNOS curses.c.<br>
<br>
SOO this potentially brings up more then just color issues,
possible instability ?<br>
<br>
What else gets 'broke' in the ARM version of JNOS ? So here
is a request from<br>
me to the PI people, please edit your makefile and add the
following :<br>
<br>
-fsigned-char<br>
<br>
to the end of the PATCHES = directive<br>
<br>
Then make clean, ./configure, make<br>
<br>
Your color should now work and hopefully JNOS will be more
stable ? Let it run<br>
for a while, notice if anything improves or gets worse ?
Whatever you can do.<br>
<br>
Thank you.<br>
<br>
Maiko / VE4KLM<br>
<br>
<br>
_______________________________________________<br>
nos-bbs mailing list<br>
<a class="moz-txt-link-abbreviated" href="mailto:nos-bbs@lists.tapr.org">nos-bbs@lists.tapr.org</a><br>
<a class="moz-txt-link-freetext" href="http://lists.tapr.org/mailman/listinfo/nos-bbs_lists.tapr.org">http://lists.tapr.org/mailman/listinfo/nos-bbs_lists.tapr.org</a><br>
</blockquote>
</blockquote>
</blockquote>
</div>
</body>
</html>