[nos-bbs] Mail bug

[Maiko Langelaar]

Actually, it's not that 'simple' after looking at it twice.

It would seem the (null) in the log entry is indeed the BID (in other
words it is null at the time it gets logged. It doesn't cause the BID
of the incoming mail to be (null), it just happens to be (null).

The piece of code is in mboxmail.c, the line is :

   /* 02Apr2016, Maiko (VE4KLM), try to log the non-fbb forwards better */
     logmbox (m->user, m->name, "msg %s queued %s", m->tomsgid);

The fix is easy, just remove the second '%s' in the format string.

But that still leaves a NULL tomsgid, which I will now have to figure
out why. for FBB type forwarding the above logs what it should, ie :

   01:03:23  44.135.48.45:1190 - MBOX (ve2har) msg 8616_db0zav queued

But for non FBB it is (null), sigh ....

Oops, and I just realized this is going to NOS-BBS list (oh well)

Maiko

On Thu, 29 Jun 2017, Brian wrote:

> A condition exists in PBBS mail forwarding where an argument isn't being
> passed causing the BID of the incoming mail to be (null). One of two
> things is happening at the incoming JNOS:
> 1) it may crash it
> 2) the receiving host may substitute the BID with the numeric from the
> mail session.
>
> A log entry may show:
> 16:20:19  I0OJJ-8 on port italy - MBOX (i0ojj) open
> 16:20:25  I0OJJ-8 on port italy - MBOX (i0ojj) incoming proposal sP wp @
> i0ojj < ik6zde
> 16:20:27  I0OJJ-8 on port italy - MBOX (i0ojj) msg (null) queued
> jnos.n1uro.ampr.org
>
> You'll notice the (null) where the BID should be.
>
> From Maiko:
> BUG confirmed, (insert colorful metaphore here)! I forgot to pass an
> argument, it's expecting 2 arguments, and I only passed it once.
> Surprised it is not crashing left right and center when it hits the log
> entry. Will fix it when I get home type of thing.
> Maiko
>
>
> -- 
> Two antennas met on a roof, fell in love and got married. The ceremony
> wasn't much, but the reception was excellent.
> --------
> 73 de Brian - N1URO/AFT1BR,
> President - EastNet Packet Network
> https://www.eastnetpacket.org
> email: (see above)
> Web: http://www.n1uro.net/
> Ampr1: http://n1uro.ampr.org/
> Ampr2: http://nos.n1uro.ampr.org
> Linux Amateur Radio Services
> axMail-Fax & URONode
> http://uronode.sourceforge.net
> http://axmail.sourceforge.net
> AmprNet coordinator for:
> Connecticut, Delaware, Maine,
> Maryland, Massachusetts,
> New Hampshire, New Jersey, Pennsylvania,
> Rhode Island, and Vermont.
>