<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)">All,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)">This is purely my opinion and experience, so take it for the $0.02 it's worth.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)">In my 35+ years of industrial experience seeing this done, I would politely suggest that this is a really bad idea.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)"><span style="font-family:-webkit-standard;font-size:medium">While the intentions are good (better and bug free code), unless the <b>entire reviewing body</b> <b>is at the same level of coding expertise</b>, it quickly turns into hurt ego's and people being insulted on both ends of the spectrum of coding expertise.</span></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)">When you have such a diverse group with widely varying backgrounds (such as this group), this usually turns into someone who only codes for a living telling people who don't 'only just code' how to do things correctly or more efficiently. <br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)">And unless the 'professional coder' has the personality to deal with this diverse backgrounds correctly (most don't), it usually ends up causing more harm and long term strained relationships which goes against a collaborative effort such as what the PSWS project is. </div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)">Not good.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)">I will not be attending any of these meetings as I'm already having a serious panic attack just writing this.... WAY too may bad experiences flooding back to torture me....</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)">John N8OBJ</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)"> </div><div><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div><div><div><div><div><div>John C. Gibbons<br></div>Director - Sears Undergraduate Design Laboratory<br></div>Dept. of Electrical Engineering and Computer Science</div></div>Case Western Reserve University <br></div><div>10900 Euclid Ave, <span style="font-size:12.8px">Glennan 314</span><span style="color:rgb(0,0,0);font-family:Helvetica;font-size:12.8px"><br></span></div></div><div><span style="color:rgb(0,0,0);font-family:Helvetica;font-size:12.8px">Cleveland, Ohio 44106-7071</span><br style="color:rgb(0,0,0);font-family:Helvetica;font-size:12.8px"><span style="color:rgb(0,0,0);font-family:Helvetica;font-size:12.8px">Phone </span><a href="tel:216-368-2816" value="+12163684572" style="color:rgb(17,85,204);font-family:Helvetica;font-size:12.8px" target="_blank">(216) 368-2816</a><span style="color:rgb(0,0,0);font-family:Helvetica;font-size:12.8px"> FAX </span><a href="tel:216-368-6888" value="+12163686888" style="color:rgb(17,85,204);font-family:Helvetica;font-size:12.8px" target="_blank">(216) 368-6888</a><br style="color:rgb(0,0,0);font-family:Helvetica;font-size:12.8px"><span style="color:rgb(0,0,0);font-family:Helvetica;font-size:12.8px">E-mail: </span><a href="mailto:jcg66@case.edu" style="color:rgb(17,85,204);font-family:Helvetica;font-size:12.8px" target="_blank">jcg66@case.edu</a><br style="color:rgb(0,0,0);font-family:Helvetica;font-size:12.8px"><br></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Aug 30, 2020 at 3:29 PM Dr. Nathaniel A. Frissell Ph.D. via TangerineSDR <<a href="mailto:tangerinesdr@lists.tapr.org">tangerinesdr@lists.tapr.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<div lang="EN-US">
<div class="gmail-m_-2755395478690123897WordSection1">
<p class="MsoNormal">Hi Bill and others,<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">I just want reiterate what this is and what this is not.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Aidan is looking to create a group where interested people who would like to show their code, ask for help, and share ideas can do so. This is not mandatory, and it is not necessarily part of the PSWS project. Maybe “Code Review” is the
wrong title for this group, and “Code Sharing, Discussion, and Help” might be better. I see this as an especially good opportunity for students who are learning to code or do data analysis to be able to talk to each other and help each other out on any HamSCI-related
coding they might be doing. This might also be good for a non-student who has wanted to take up a new language, like Python, and be able to talk to others about what they are doing.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">I hope that there are people who will find this a helpful sharing session.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">73 de Nathaniel W2NAF<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div style="border-style:solid none none;border-top-width:1pt;border-top-color:rgb(225,225,225);padding:3pt 0in 0in">
<p class="MsoNormal"><b>From:</b> TangerineSDR <<a href="mailto:tangerinesdr-bounces@lists.tapr.org" target="_blank">tangerinesdr-bounces@lists.tapr.org</a>>
<b>On Behalf Of </b>Engelke, Bill via TangerineSDR<br>
<b>Sent:</b> Sunday, August 30, 2020 3:04 PM<br>
<b>To:</b> TAPR TangerineSDR Modular Software Defined Radio <<a href="mailto:tangerinesdr@lists.tapr.org" target="_blank">tangerinesdr@lists.tapr.org</a>><br>
<b>Cc:</b> Engelke, Bill <<a href="mailto:bill.engelke@ua.edu" target="_blank">bill.engelke@ua.edu</a>><br>
<b>Subject:</b> Re: [TangerineSDR] [EXTERNAL] Re: Code Review<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Aiden – I don’t wish to be uncooperative, but this could be a significant increase in scope; so I will not be participating in any code reviews until directed to do so by the UA Principal Investigator (Dr. Travis Atkinson). If you want
to pursue this, please go thru the chain of command, i.e., ask Nathaniel (chief PI) to pass this new requirement to our team thru Dr. Atkinson. -73- Bill AB4EJ<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><b>From:</b> TangerineSDR <<a href="mailto:tangerinesdr-bounces@lists.tapr.org" target="_blank">tangerinesdr-bounces@lists.tapr.org</a>>
<b>On Behalf Of </b>Aidan Montare via TangerineSDR<br>
<b>Sent:</b> Sunday, August 30, 2020 11:03 AM<br>
<b>To:</b> <a href="mailto:hamsci@googlegroups.com" target="_blank">hamsci@googlegroups.com</a>; TAPR TangerineSDR Modular Software Defined Radio <<a href="mailto:tangerinesdr@lists.tapr.org" target="_blank">tangerinesdr@lists.tapr.org</a>><br>
<b>Cc:</b> Aidan Montare <<a href="mailto:aam141@case.edu" target="_blank">aam141@case.edu</a>><br>
<b>Subject:</b> [EXTERNAL] Re: [TangerineSDR] Code Review<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<div>
<p class="MsoNormal">Dear all,<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Thanks everyone for sharing your thoughts on my proposal for hamsci code review sessions! I really appreciate the feedback.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Please fill out the form (<a href="https://forms.gle/uiEHCqMG9v1BaQiW7" target="_blank">https://forms.gle/uiEHCqMG9v1BaQiW7</a>)
<b>by this Thursday</b> if you haven't already so that I can schedule a time. My college semester just began this week, so I mostly know my own schedule and can pick a time.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Also, I wanted to provide some comments that will hopefully clarify a few things:<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">The code review sessions are intended to be pretty informal. I want a space for people to talk about programming in our projects, get help on topics they would like to discuss, and polish the aspects of their work they'd like to polish.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">As Kristina pointed out, "code review" is a bit of a reserved word in certain groups, and often means a specific thing. I'm not trying to be so formal (perhaps I should have called them by a different name). I don't expect that anyone has
to follow any of the recommendations they get at any of the sessions. And I don't expect that all code written in HamSCI has to go through code review.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Also, these sessions are half for the benefit of our projects, and half for everyone's individual benefit. Part of my motivation is the desire to personally improve my own abilities, and I hope that others will learn things as well. I appreciate
the sentiment that not all good ideas might be implemented now, but some might be worth remembering for the future. If someone decides that we can't implement an idea now, but learns something that can be applied in their future projects, I'd consider that
a success.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Finally, I'm a bit of a nerd, and I do personally enjoy learning about things like programming standards. But my intent of code review is not to propose any coding standard or style guide.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">I hope that makes my thoughts a bit clearer. I continue to appreciate the feedback, and enjoy the discussions. Hearing from everyone’s different experiences is one of my favorite parts of hamsci!<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><br>
-- <u></u><u></u></p>
<div>
<div>
<p class="MsoNormal">Sincerely,<br>
<br>
Aidan Montare<br>
CWRU Class of 2021<u></u><u></u></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
-- <br>
TangerineSDR mailing list<br>
<a href="mailto:TangerineSDR@lists.tapr.org" target="_blank">TangerineSDR@lists.tapr.org</a><br>
<a href="http://lists.tapr.org/mailman/listinfo/tangerinesdr_lists.tapr.org" rel="noreferrer" target="_blank">http://lists.tapr.org/mailman/listinfo/tangerinesdr_lists.tapr.org</a><br>
</blockquote></div>