[nos-bbs] FBB error handling: 1 error? and 1 improvement request

[Michael Fox - N6MEF]

Maiko,

One error (I think) and one improvement request regarding FBB error
handling:


1) End of line termination error?

In the example below, N6MEF is jnos 2.0j.7v with "bleeding edge" fixes.
AG6QO is a BPQ station.
Look at the last two packets.  Notice that the "*** Protocole" (sp?) line
sent by JNOS ends with only a line feed (\x0a) and the "FQ" line ends with
only a carriage return (\x0d).  Both should end with CRLF (\x0d\x0a), right?

Date/Time					Src	Dst	Telnet Data

Apr 18, 2016 03:48:35.016291000	N6MEF	ag6qo	\x0d\x0a,JNOS
(n6mef.ampr.org)\x0d\x0a,\x0d\x0a,login: 
Apr 18, 2016 03:48:35.093917000	ag6qo	N6MEF
.AG6QO\x0d\x0a,********\x0d\x0a
Apr 18, 2016 03:48:35.094427000	N6MEF	ag6qo	Password: 
Apr 18, 2016 03:48:35.133692000	N6MEF	ag6qo
\x0d[JNOS-2.0j.7v.XSC32.3-BFHIM$]\x0d>\x0d
Apr 18, 2016 03:48:35.519054000	ag6qo	N6MEF
[BPQ-6.0.12.25-BFIHJM$]\x0dFA B G8MNY WW TECH 1766_GB7CIP 3361\x0dFA B G8MNY
WW TECH 1767_GB7CIP 4976\x0dF> 04\x0d
Apr 18, 2016 03:48:35.523969000	N6MEF	ag6qo	FS ++\x0d
Apr 18, 2016 03:48:36.071589000	ag6qo	N6MEF	\x01!Ferrite Ring Demo
circuit
Apr 18, 2016 03:48:36.105448000	ag6qo	N6MEF	N\xd5\x12\x96[.binary data
clipped for brevity.]
Apr 18, 2016 03:48:36.107784000	N6MEF	ag6qo	*** Protocole Error (3)\x0a
Apr 18, 2016 03:48:36.133338000	N6MEF	ag6qo	FQ\x0d


2) Nos.log improvement request:  please preface errors with connection info

This is the JNOS log of the above telnet session.  The "fbb protocol error"
line doesn't say which connection it belongs to at all.  The "lzhuf" and
"FBBFWD" lines don't include the "MBOX(ag6qo)" info.  When multiple
connections are happening at the same time, the entries in nos.log can be
interspersed.  It would be helpful to know which connection the error
belongs to.  So, at a minimum, the "<ip-addr>:<port>" (or "<callsign> on
port <port>") info is needed.  If the "MBOX (<callsign>) info were also
present it would make it easier to find all log lines with "grep 'MBOX
(<callsign>)'".

Mon Apr 18 03:48:35 2016  76.14.186.245:44915 - possible airmail telnet
client ...
Mon Apr 18 03:48:35 2016  76.14.186.245:44915 - MBOX (ag6qo) login
Mon Apr 18 03:48:35 2016  76.14.186.245:44915 - MBOX (ag6qo) open
Mon Apr 18 03:48:35 2016  76.14.186.245:44915 - MBOX (ag6qo) forwarding
Mon Apr 18 03:48:35 2016  76.14.186.245:44915 - MBOX (ag6qo) incoming
proposal FA B G8MNY WW TECH 1766_GB7CIP 3361
Mon Apr 18 03:48:35 2016  76.14.186.245:44915 - MBOX (ag6qo) incoming
proposal FA B G8MNY WW TECH 1767_GB7CIP 4976
Mon Apr 18 03:48:35 2016  76.14.186.245:44915 - MBOX (ag6qo) our response FS
++
Mon Apr 18 03:48:36 2016  - fbb protocol error, expecting STX or EOT
Mon Apr 18 03:48:36 2016  76.14.186.245:44915 - lzhuf: detected FBB protocol
error 3
Mon Apr 18 03:48:36 2016  76.14.186.245:44915 - FBBFWD: recv_yapp() error.
Mon Apr 18 03:48:36 2016  76.14.186.245:44915 - MBOX (ag6qo) FBB error, last
read : F> 04
Mon Apr 18 03:48:36 2016  76.14.186.245:44915 - MBOX (ag6qo) exit

Michael
N6MEF